search

JuliaMath / Calculus.jl

Calculus functions in Julia
Other
275 stars 78 forks source link

remove call to simplify() in differentiate() #124

Closed mlubin closed 6 years ago

mlubin commented 6 years ago

The recent change (https://github.com/JuliaMath/Calculus.jl/commit/e71569d56f40daeb95cbb6454b512a26b149cab5#diff-5a6fead5de693e2e71f15ab0d20c177dL96) causes very verbose warnings when simplify() is called from another module. Whenever JuMP is precompiled it now prints

WARNING: eval from module Calculus to Derivatives:    
Expr(:call, :/, 1, 2)::Any
  ** incremental compilation may be broken for this module **

WARNING: eval from module Calculus to Derivatives:    
Expr(:call, :/, 1, 2)::Any
  ** incremental compilation may be broken for this module **
...

The easiest workaround I could find is to stop calling simplify() from differentiate(), so that differentiate() can be called from outside Calculus without warnings until simplify() is fixed.

https://github.com/JuliaOpt/JuMP.jl/issues/1299 https://github.com/mlubin/ReverseDiffSparse.jl/issues/50

mlubin commented 6 years ago

I will tag this in a day or so since the issue actively affects all JuMP users (on the initial compile). @ararslan

ararslan commented 6 years ago

Sounds good to me. Tag at will 👍