search

JuliaMath / Calculus.jl

Calculus functions in Julia
Other
275 stars 78 forks source link

Adjoint overload for `::Function` is type piracy #133

Closed tkoolen closed 4 years ago

tkoolen commented 4 years ago

https://github.com/JuliaMath/Calculus.jl/blob/4da2f9b6d29d3c30bb761b9dcab9e6528492d231/src/derivative.jl#L32-L36

Is type piracy. Zygote is now similarly committing type piracy (https://github.com/FluxML/Zygote.jl/issues/260), leading to warnings like

WARNING: Method definition adjoint(Function) in module Zygote at /home/twan/.julia/packages/Zygote/fuj2C/src/compiler/interface.jl:50 overwritten in module Calculus at /home/twan/.julia/packages/Calculus/2qBLt/src/derivative.jl:33.