codecov[bot]
commented
1 year ago Codecov Report
Base: 96.85% // Head: 96.85% // No change to project coverage :thumbsup:
Coverage data is based on head (
7ceb259) compared to base (d1b633b). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #129 +/- ## ======================================= Coverage 96.85% 96.85% ======================================= Files 7 7 Lines 700 700 ======================================= Hits 678 678 Misses 22 22 ``` | [Impacted Files](https://codecov.io/gh/JuliaMath/Combinatorics.jl/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [src/combinations.jl](https://codecov.io/gh/JuliaMath/Combinatorics.jl/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-c3JjL2NvbWJpbmF0aW9ucy5qbA==) | `85.27% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Closes Issues #86 and #123. Currently the output of
combinations(a)does not include the empty combination, which is a bug. Also in the tests, we should havecombinations([]) = [[]], i.e., an array that contains the empty set, not the empty set itself.