JuliaMath / Combinatorics.jl

A combinatorics library for Julia
http://juliamath.github.io/Combinatorics.jl/dev/
Other
214 stars 58 forks source link

Add tests based on python's itertools #130

Open natemcintosh opened 1 year ago

natemcintosh commented 1 year ago

Feel free to ignore and close this PR without explanation.

The basic idea here is to test the Julia version against the python itertools.

Assumptions: python's itertools library is correct.

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.97% // Head: 96.97% // No change to project coverage :thumbsup:

Coverage data is based on head (a597eb0) compared to base (8a7a8ac). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ======================================= Coverage 96.97% 96.97% ======================================= Files 7 7 Lines 728 728 ======================================= Hits 706 706 Misses 22 22 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

natemcintosh commented 1 year ago

Looks like the failure on Julia 1.0 on windows is because PyCall failed to build. Not sure how to get around that