search

JuliaMath / Combinatorics.jl

A combinatorics library for Julia
http://juliamath.github.io/Combinatorics.jl/dev/
Other
214 stars 58 forks source link

inline iterate method to avoid allocations #148

Open GregPlowman opened 9 months ago

GregPlowman commented 9 months ago

Use @inline on iterate method of Combinations to avoid allocations when creating return tuple

Closes #147

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e6888be) 96.97% compared to head (eb654a5) 96.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #148 +/- ## ========================================== - Coverage 96.97% 96.97% -0.01% ========================================== Files 7 7 Lines 728 727 -1 ========================================== - Hits 706 705 -1 Misses 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knuesel commented 5 months ago

Any reason not to merge this?