search

JuliaMath / Combinatorics.jl

A combinatorics library for Julia
http://juliamath.github.io/Combinatorics.jl/dev/
Other
215 stars 58 forks source link

Add `multiset_permutations` method that doesn't require length #164

Open oscardssmith opened 5 months ago

oscardssmith commented 5 months ago

in analogy to the same case for regular permuations

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.41%. Comparing base (a303e88) to head (6afa6f0).

:exclamation: Current head 6afa6f0 differs from pull request most recent head 2813a19. Consider uploading reports for the commit 2813a19 to get more accurate results

Files Patch % Lines
src/permutations.jl 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #164 +/- ## ========================================== - Coverage 96.89% 96.41% -0.48% ========================================== Files 8 8 Lines 804 808 +4 ========================================== Hits 779 779 - Misses 25 29 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

inkydragon commented 5 months ago

Maybe add some tests or doctests

oscardssmith commented 5 months ago

test added.

oscardssmith commented 4 months ago

should this be merged?