Sumegh-git commented 5 years ago

Ping @mschauer

Added support for 2 more combinatorial numbers used frequently in counting and partition problems - Lobb Number and Narayana Number. Also added tests and updated README Please do suggest any changes required or any extra additions needed to this PR. Thanks.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8d95714). Click here to learn what that means. The diff coverage is 60%.

@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage          ?   75.55%           
=========================================
  Files             ?        7           
  Lines             ?      630           
  Branches          ?        0           
=========================================
  Hits              ?      476           
  Misses            ?      154           
  Partials          ?        0

Impacted Files	Coverage Δ
src/numbers.jl	`85.33% <60%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d95714...9aa1d23. Read the comment docs.

Sumegh-git commented 5 years ago

Pushed a commit addressing the reviews.

Sumegh-git commented 5 years ago

I thought it would be good to do so. Anyways, if you think those shouldn't be exported , i'll remove it. What do you say?

mschauer commented 5 years ago

I agree. I'll leave it open for a while and then eventually merge if there are no objections.

JuliaMath / Combinatorics.jl

Added Lobb and Narayana numbers #76

Codecov Report