search

JuliaMath / Combinatorics.jl

A combinatorics library for Julia
http://juliamath.github.io/Combinatorics.jl/dev/
Other
215 stars 58 forks source link

Broaden types accepted by stirlings1 and stirlings2 functions #83

Closed wherrera10 closed 5 years ago

wherrera10 commented 5 years ago

The functions stirlings1(n, k) and stirlings2(n, k) are currently (mid 2019) written to specify Int arguments for n and k, but the documentation states that they should optionally take a BigInt as well. This can be fixed by changing them not to specify an Int for n and k.

codecov-io commented 5 years ago

Codecov Report

Merging #83 into master will increase coverage by 18.89%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #83       +/-   ##
==========================================
+ Coverage   75.51%   94.4%   +18.89%     
==========================================
  Files           7       7               
  Lines         637     518      -119     
==========================================
+ Hits          481     489        +8     
+ Misses        156      29      -127
Impacted Files Coverage Δ
src/numbers.jl 100% <100%> (+14.66%) :arrow_up:
src/combinations.jl 80.64% <0%> (+15.98%) :arrow_up:
src/multinomials.jl 88.88% <0%> (+16.16%) :arrow_up:
src/permutations.jl 97.64% <0%> (+17.06%) :arrow_up:
src/youngdiagrams.jl 93.93% <0%> (+19.24%) :arrow_up:
src/partitions.jl 97.54% <0%> (+21.83%) :arrow_up:
src/factorials.jl 100% <0%> (+23.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38fc5c4...4b2c99a. Read the comment docs.