search

JuliaMath / Cubature.jl

One- and multi-dimensional adaptive integration routines for the Julia language
Other
126 stars 21 forks source link

Fix for 0.6 #23

Closed yuyichao closed 7 years ago

yuyichao commented 7 years ago

DO NOT MERGE NOW!

~~The broadcast fix is independent and is missing @compat. The cfunction fix requires https://github.com/JuliaLang/julia/pull/19801 and can also be further improved to eliminate dynamic dispatch in the callback. This is used mainly as a use/test case for https://github.com/JuliaLang/julia/pull/19801. ~~

yuyichao commented 7 years ago

This version passes tests on 0.4, 0.5 and 0.6 with JuliaLang/julia#19801. It should not have any dynamic dispatch in the callback on 0.5 and 0.6.

yuyichao commented 7 years ago

I should mention that the fix does not rely on JuliaLang/julia#19801 anymore and should be ready to go.

stevengj commented 7 years ago

Thanks! Can you put together a PR to update the C-callback blog post at some point?

yuyichao commented 7 years ago

Well, I guess it's still unclear what https://github.com/JuliaLang/julia/pull/19801 will become. Currently there isn't a semantic for cfunction so it's hard to describe...