search

JuliaMath / DensityInterface.jl

Interface for mathematical/statistical densities in Julia
Other
12 stars 3 forks source link

Update interface.jl #7

Closed phipsgabler closed 2 years ago

phipsgabler commented 2 years ago

AFAIK, shouldn't throw objects that are not Exceptions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #7 (f82c3b9) into master (7c4718a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           36        37    +1     
=========================================
+ Hits            36        37    +1
Impacted Files Coverage Δ
src/interface.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c4718a...f82c3b9. Read the comment docs.

oschulz commented 2 years ago

Oh, indeed, that's a bug. We forgot to wrap the string in an ArgumentError().

oschulz commented 2 years ago

Thanks @phipsgabler !

oschulz commented 2 years ago

https://github.com/JuliaRegistries/General/pull/48407