search

JuliaMath / FFTW.jl

Julia bindings to the FFTW library for fast Fourier transforms
https://juliamath.github.io/FFTW.jl/stable
MIT License
273 stars 55 forks source link

CI: for the macOS CI jobs with the MKL provider, force MKL_jll 2023 to be installed #286

Closed DilumAluthge closed 10 months ago

DilumAluthge commented 10 months ago

In MKL 2024, Intel dropped support for macOS.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (76732cd) 70.88% compared to head (4bd5b40) 70.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #286 +/- ## ======================================= Coverage 70.88% 70.88% ======================================= Files 5 5 Lines 529 529 ======================================= Hits 375 375 Misses 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giordano commented 10 months ago

Use MKL 2023 for testing those jobs, so we do something actually useful?

DilumAluthge commented 10 months ago

Use MKL 2023 for testing those jobs, so we do something actually useful?

Done!

ericphanson commented 10 months ago

What about using Pkg.add then Pkg.pin so it can't re-resolve it? (@palday's idea in an unrelated repo)