search

JuliaMath / FFTW.jl

Julia bindings to the FFTW library for fast Fourier transforms
https://juliamath.github.io/FFTW.jl/stable
MIT License
273 stars 55 forks source link

Update CI.yml for Apple Silicon #296

Closed ViralBShah closed 8 months ago

ViralBShah commented 8 months ago

Enabling Apple Silicon is a bit messy because of the cross product of all platforms. It's good to be able to test it though, and happy to improve the script if anyone has suggestions for simplification.

Is it useful to run all the tests on Julia nightly? I feel we can save CI time by removing nightly.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.08%. Comparing base (c77f59d) to head (ef4e730).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #296 +/- ## ======================================= Coverage 73.08% 73.08% ======================================= Files 5 5 Lines 535 535 ======================================= Hits 391 391 Misses 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ViralBShah commented 8 months ago

The failing CI case is because the runner is unable to download MKL (despite several attempts).

ViralBShah commented 8 months ago

@DilumAluthge Any ideas how to get the failing action to pass? It can't download MKL_jll repeatedly. Perhaps safe to merge?

ViralBShah commented 8 months ago

@ararslan Would it be ok to disable nightly in the CI?

ararslan commented 7 months ago

@ararslan Would it be ok to disable nightly in the CI?

Sorry, I just saw this. Perhaps we could simplify to only a single nightly job, e.g. just run on Linux x64? Testing on nightly can be useful to ensure upstream changes don't affect the package in unexpected ways but IMO a single platform would suffice.

ViralBShah commented 7 months ago

Yes makes sense. I'll add that shortly.