search

JuliaMath / FixedPointNumbers.jl

fixed point types for julia
Other
80 stars 33 forks source link

Change test targets of `Fixed` #218

Closed kimikage closed 4 years ago

kimikage commented 4 years ago

During the revision of PR #208, I unintentionally dropped the upper limit of the number of fractional bits f for Fixed (e.g. Q0f7 --> Q0f6).

Of course, the tests should be passed independent of f, so ideally the selection of fs makes no difference. However, in general, the quality of tests is higher when using boundary values. In fact, two edge cases (but not a bug) have been detected.

codecov[bot] commented 4 years ago

Codecov Report

Merging #218 into master will increase coverage by 0.80%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   88.55%   89.35%   +0.80%     
==========================================
  Files           6        6              
  Lines         498      498              
==========================================
+ Hits          441      445       +4     
+ Misses         57       53       -4
Impacted Files Coverage Δ
src/fixed.jl 92.92% <0.00%> (+3.03%) :arrow_up:
src/utilities.jl 92.00% <0.00%> (+4.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5dcaf97...cbabab6. Read the comment docs.