JuliaMath / FixedPointNumbers.jl

fixed point types for julia

Other

80 stars 33 forks source link

Use GitHub Actions for unit testing on Arm arch. #238

Closed kimikage closed 3 years ago

kimikage commented 3 years ago

The test runs on a docker container with QEMU. This also updates TagBot.yml.

Closes #237

codecov[bot] commented 3 years ago

Codecov Report

Merging #238 (e933aeb) into master (1e14ce6) will decrease coverage by 0.78%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   96.46%   95.68%   -0.79%     
==========================================
  Files           6        6              
  Lines         736      742       +6     
==========================================
  Hits          710      710              
- Misses         26       32       +6

Impacted Files	Coverage Δ
src/fixed.jl	`96.89% <0.00%> (-1.22%)`	:arrow_down:
src/FixedPointNumbers.jl	`95.75% <0.00%> (-0.95%)`	:arrow_down:
src/normed.jl	`95.47% <0.00%> (-0.44%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e14ce6...e933aeb. Read the comment docs.

johnnychen94 commented 3 years ago

😱 the CI is unpredictable.

johnnychen94 commented 3 years ago

Perhaps temporarily remove .github/workflows/UnitTest.yml?

kimikage commented 3 years ago

I spent half the day on this silly typo. :joy: shell: bin/bash ->shell: /bin/bash

It should not be necessary to download julia in the container. However, setup-julia also does not support arm.

kimikage commented 3 years ago

test (1.0, ... 27m 29s test (1, ... 43m 18s test (nightly, ... 26m 2s

Although I had expected it, it seems too slow. :sob: However, compared to Travis CI, GitHub Actions has a higher parallelism, so the total time does not seem to be drastically different. Umm....

kimikage commented 3 years ago

There is some room for improvement, but I'd like to try this out first.

Thank you, Travis CI, for all your support!

johnnychen94 commented 3 years ago

Is the slow CI time a container issue, or just FixedPointNumbers has bad performance in Arm?

kimikage commented 3 years ago

I think the speed depends on the CI environment. At least the Travis CI tests which ran on the Arm machine were 2-3 times faster per configuration (i.e. julia-version).

I don't have a fast Arm machine, though.