JuliaMath / FixedPointNumbers.jl

fixed point types for julia
Other
79 stars 34 forks source link

use Random explicitly #270

Closed vchuravy closed 4 months ago

vchuravy commented 8 months ago

In Julia 1.11 some work has been done to move standard libraries out of the "sysimage" and also make them upgradable (so they would no longer be strongly tied to the Julia version). The Random stdlib is a bit special in the sense that it commits "type piracy" by overloading the Base.rand function for types that it doesn't own. An example of that is rand() which is defined in Random. While code will still be able to call rand() etc in 1.11 without loading Random there are some performance implications that makes it so it is better to load Random up front.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0edec16) 96.56% compared to head (ced5c27) 96.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #270 +/- ## ======================================= Coverage 96.56% 96.56% ======================================= Files 6 6 Lines 785 785 ======================================= Hits 758 758 Misses 27 27 ``` | [Files](https://app.codecov.io/gh/JuliaMath/FixedPointNumbers.jl/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [src/precompile.jl](https://app.codecov.io/gh/JuliaMath/FixedPointNumbers.jl/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.