search

JuliaMath / FixedPointNumbers.jl

fixed point types for julia
Other
79 stars 34 forks source link

Fix test for exponentially growing `promote_type` #280

Closed kimikage closed 3 months ago

kimikage commented 3 months ago

This follows the behavior, i.e. the order of evaluation, in Base. It was changed recently in the nightly build (cf. https://github.com/JuliaLang/julia/pull/53665), and it might be changed further in the future.

julia> VERSION
v"1.12.0-DEV.283"

julia> promote_type(N0f8, N1f7, N2f6, N3f5, N4f4, N5f3)
N8f8 (alias for Normed{UInt16, 8})

I thought Julia was getting very smart, but that was not the case. 😆

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.07%. Comparing base (8b9119c) to head (889dcbd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #280 +/- ## ======================================= Coverage 97.07% 97.07% ======================================= Files 6 6 Lines 785 785 ======================================= Hits 762 762 Misses 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.