binary_maxheap is deprecated

JuliaMath / HCubature.jl

pure-Julia multidimensional h-adaptive integration

Other

153 stars 25 forks source link

binary_maxheap is deprecated #14

Closed yakir12 closed 5 years ago

yakir12 commented 5 years ago

┌ Warning: `binary_maxheap(::Type{T}) where T` is deprecated, use `BinaryMaxHeap{T}()` instead.
│   caller = hcubature_(::Function, ::SArray{Tuple{2},Float64,1,2}, ::SArray{Tuple{2},Float64,1,2}, ::typeof(LinearAlgebra.norm), ::Int64, ::Int64, ::Int64, ::Int64) at HCubature.jl:64
└ @ HCubature ~/.julia/packages/HCubature/BNvCh/src/HCubature.jl:64

stevengj commented 5 years ago

Thanks, a PR updating this (and bumping the DataStructures requirement) would be welcome.

yakir12 commented 5 years ago

Sorry, I'm not sure what you mean with "bumping the DataStructures requirement", I looked in the REQUIRE file and you don't have any limitations set on the version of DataStructures, so not sure what you meant. Hope this is helpful :slightly_smiling_face: