search

JuliaMath / IntelVectorMath.jl

Julia bindings for the Intel Vector Math Library
Other
73 stars 18 forks source link

update for Julia v0.7 #13

Closed RalphAS closed 4 years ago

mschauer commented 6 years ago

Thank you! In the PR the new naming convention for exported functions is vlog(a) and log!(a) ( to avoid conflicts with base). Just to mention, https://github.com/JuliaMath/Yeppp.jl in a similar niche uses Yeppp.log and Yeppp.log!.

mschauer commented 6 years ago

Related older issue tracking consistency of interfaces over there: https://github.com/JuliaMath/Yeppp.jl/issues/9

KristofferC commented 6 years ago

FWIW, I like prefixing with the module name.

RalphAS commented 6 years ago

Ok, to make the interface consistent with others I'll switch to VML.log, VML.log! etc. and stop exporting the bindings. Revision in progress.

mschauer commented 6 years ago

Actually, maybe it is good to discuss this first. I like the module-name prefix too. On the other hand, using a function vlog and vlog! means that code is oblivious to which packages actually provides these functions and switching VML with Yeppp eg becomes easier.

RalphAS commented 6 years ago

An alternative would be an umbrella package which aliases the bindings of whichever one is installed, maybe managed by Requires.jl

Djoop commented 5 years ago

Maybe the PR should be merged so that the package can be installed on julia≥0.7, keeping the creation of an umbrella package an option for the future? I personally like prefixing with the module name, and given that e.g. Yeppp and VML export different subsets of functions I'm not convinced that a separate package would really make the choice cleaner (but I might be wrong!).

aminya commented 4 years ago

This should be closed because there another PR for Julia 1 is ready to go: https://github.com/JuliaMath/VML.jl/pull/17

aminya commented 4 years ago

@ViralBShah Please close this as it is not applicable anymore.