search

JuliaMath / IntelVectorMath.jl

Julia bindings for the Intel Vector Math Library
Other
73 stars 18 forks source link

Wrong linking for the CIS function #15

Closed Djoop closed 4 years ago

Djoop commented 5 years ago

Hi, I am not sure to fully understand the naming conventions, but the actual code uses the input types to detect the function prefix (like _vmld, _vmlz). This works for most functions (that have the same input and output types), but not for CIS, which takes reals and returns complex numbers, but is defined as _vmlcCIS and _vlczCIS. I don't think we should use the output type instead, given that Arg (angle) does the opposite (complex->float, but also defined as _vmlcArg and _vmlzArg). So I don't know what is the cleanest way to solve this case, but using a different prefix just for CIS does solve the problem. Sorry I'm not sure how to make a clean pull request as I already cloned the repo from the v0.7 PR, that has not been merged yet.

Crown421 commented 4 years ago

I looked into this, unfortunately this is not consistent within VML, so it is not as easy as just picking the VML function based on output instead of input type. Happy to put your solution in.

Crown421 commented 4 years ago

Pull request https://github.com/JuliaMath/VML.jl/pull/17 now contains CIS.

aminya commented 4 years ago

Closed by https://github.com/JuliaMath/VML.jl/pull/17