JuliaMath / Interpolations.jl

Fast, continuous interpolation of discrete datasets in Julia
http://juliamath.github.io/Interpolations.jl/
Other
523 stars 110 forks source link

Deprecated convenience constructors don't accept keyword arguments #507

Closed danielmatz closed 2 years ago

danielmatz commented 2 years ago

The deprecated camel case convenience constructors (see #501) don't accept keyword arguments. It seems that @deprecate only passes along positional arguments by default. I think this can be fixed by doing:

@deprecate LinearInterpolation(args...; kwargs...) linear_interpolation(args...; kwargs...)
mkitti commented 2 years ago

Oh that's a problem, ok fixing.

mkitti commented 2 years ago

@danielmatz can you confirm that the issue is resolved at version 0.14.3?

danielmatz commented 2 years ago

@mkitti Looks good! Thanks!

mkitti commented 2 years ago

Thank you for the report.