JuliaMath / Interpolations.jl

Fast, continuous interpolation of discrete datasets in Julia
http://juliamath.github.io/Interpolations.jl/
Other
523 stars 110 forks source link

Add Previous and Next for Constant interpolation #512

Closed judober closed 2 years ago

judober commented 2 years ago

Fix #511

I thought of adding Constant{Mode}() to the docstring of interpolate but was not shure if this is apropriate. Thereby I noted that these docstring have different entries which seem inconsistent/incomplete. E.g. once there is BSpline(NoInterp()) and once only NoInterp(). Also these do not reflect the posibility of using Gridded.

codecov[bot] commented 2 years ago

Codecov Report

Merging #512 (1de4c3f) into master (e6d076a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files          28       28           
  Lines        1846     1846           
=======================================
  Hits         1608     1608           
  Misses        238      238           
Impacted Files Coverage Δ
src/b-splines/constant.jl 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mkitti commented 2 years ago

I think expanding the doc string for Constant is sufficient, but I will think about discoverability more later.

mkitti commented 2 years ago

Documentation preview: https://juliamath.github.io/Interpolations.jl/previews/PR512

mkitti commented 2 years ago

I'm not sure why the preview is not working. I'll investigate later.

judober commented 2 years ago

Anything left to do here?

mkitti commented 2 years ago

Looks good to me