JuliaMath / Interpolations.jl

Fast, continuous interpolation of discrete datasets in Julia
http://juliamath.github.io/Interpolations.jl/
Other
523 stars 110 forks source link

remove unbound type parameters #516

Closed nsajko closed 2 years ago

nsajko commented 2 years ago

I didn't check, but unbound type parameters often cause performance issues, so this may not be merely cosmetic.

codecov[bot] commented 2 years ago

Codecov Report

Merging #516 (a5ae1bd) into master (006a0a5) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files          28       28           
  Lines        1846     1846           
=======================================
  Hits         1608     1608           
  Misses        238      238           
Impacted Files Coverage Δ
src/Interpolations.jl 75.92% <0.00%> (ø)
src/gridded/gridded.jl 98.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mkitti commented 2 years ago

Looks good to me, thanks. Did you have a way for screening for these automatically?

nsajko commented 2 years ago

a way for screening for these automatically?

Try nightly Julia: https://github.com/JuliaLang/julia/pull/46608

mkitti commented 2 years ago

I'm going to merge this, thanks.