Closed wg030 closed 2 years ago
Base: 87.10% // Head: 87.17% // Increases project coverage by +0.06%
:tada:
Coverage data is based on head (
7e51dff
) compared to base (d38ae2e
). Patch coverage: 97.95% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@mkitti Thanks for reviewing my contribution! I wrote down my thoughts on your comments. For now, I will correct the spelling misstakes and we can discuss the other suggestions.
ready to merge?
ready to merge?
Today I thought about adding some convenience constructors for all those monotonic interpolations types, too, which I might do in the next few days. But if you want to merge this PR already, go ahead, it is already mergeable!
ready to merge?
Today I thought about adding some convenience constructors for all those monotonic interpolations types, too, which I might do in the next few days. But if you want to merge this PR already, go ahead, it is already mergeable!
Could you sketch out the thoughts for convenience constructors in an issue so we can discuss?
Could you sketch out the thoughts for convenience constructors in an issue so we can discuss?
Sure! I would suggest that we merge this one and I will open a new issue for the discussion of adding convenience constructors outlining my idea!
merged
Thanks for merging, @mkitti
Do you know how long it will take until updating the package with (@v1.8) pkg> up
will apply theses changes, too?
I know that (@v1.8) pkg> add Interpolations#master
will do the job, but I always wondered how the mechanism of the official update process works.
Honestly, I thought that changing version = "0.14.5"
to version = "0.14.6"
in Project.toml
within the PR like I did would already trigger the official update,too. Turns out that was a false assumption 😂
I need to register it.
I need to register it.
Alright, I see. It's rather a manual process that an automatic one. Now I understand why some packages are officially updated half a year or so later after their update on github.
If that's the case, then you could file an issue or comment on the last commit to master and suggest registering the current state. The registration process is highly automated and efficient, but it requires a maintainer to launch it.
If that's the case, then you could file an issue or comment on the last commit to master and suggest registering the current state. The registration process is highly automated and efficient, but it requires a maintainer to launch it.
Ah ok, thanks for the clearfication. I think i got it now. It's bascially an automated process which is triggered by the maintainer by commenting
@JuliaRegistrator register
to the latest commit, isn't it? At least that's what happened here and now (@v1.8) pkg> up
seems to be up to date with the content of this github repo.
Error while trying to register: Register Failed @wg030, it looks like you are not a publicly listed member/owner in the parent organization (JuliaMath). If you are a member/owner, you will need to change your membership to public. See GitHub Help
I added the new interpolation type
AkimaMonotonicInterpolation
and tested the implementation by comparing the results with the results of working code for Akima splines. I also ran the tests for@testset "Monotonic"
successfully and checked the plots created by test/plots/monotonic/sanity.jl