Closed sjkelly closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4b617f6
) 87.85% compared to head (b412a30
) 87.17%. Report is 3 commits behind head on master.:exclamation: Current head b412a30 differs from pull request most recent head dedab7a. Consider uploading reports for the commit dedab7a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Okay I realize while fixing the docs builds that StaticArraysCore removed some constructors and converts. There are some holes in coverage that we will need to plug to make sure that all calls to SVector
are okay.
We should revisit this.
Does Interpolations
only return static arrays when static arrays collections are passed as arguments?
If yes: the new Julia 1.9 feature "package extensions" can be used to use StaticArrays
only when they are already loaded by the user.
If no: when else does it return static arrays? Maybe these cases could be removed?
We may be using it internally as well. I'll have to double check.
I think this is a good idea, but this is going to need more refactoring for it to work.
This package primarily uses the SVector as a return type, instead of using the operations on said SVector. Therefore StaticArraysCore provides immense improvements to loads time:
before:
after:
I would argue though that an NTuple would be sufficent return type in most cases. Though that is a breaking change and can remain an idea for a major release.