search

JuliaMath / Interpolations.jl

Fast, continuous interpolation of discrete datasets in Julia
http://juliamath.github.io/Interpolations.jl/
Other
518 stars 110 forks source link

Some recursion tuning to allow more eager inference. #568

Closed N5N3 closed 9 months ago

N5N3 commented 9 months ago

Before julia 1.11, indirect recursion might cause unwanted type widening and leading to bad inference. itp(...), gradient(itp, ...), hessian(itp, ...) would therefore become unstable if itp has some NoInterp dim. This PR fix it, MWE has been added to Test.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (43fe00f) 87.87% compared to head (21f8b76) 87.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #568 +/- ## ========================================== + Coverage 87.87% 87.93% +0.06% ========================================== Files 28 28 Lines 1880 1890 +10 ========================================== + Hits 1652 1662 +10 Misses 228 228 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mkitti commented 9 months ago

Thanks