search

JuliaMath / InverseFunctions.jl

Interface for function inversion in Julia
Other
29 stars 8 forks source link

fix invpow and invlog domains #23

Closed aplavin closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (42139b3) compared to base (34c1adf). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #23 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 74 89 +15 ========================================= + Hits 74 89 +15 ``` | [Impacted Files](https://codecov.io/gh/JuliaMath/InverseFunctions.jl/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [src/functions.jl](https://codecov.io/gh/JuliaMath/InverseFunctions.jl/pull/23/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-c3JjL2Z1bmN0aW9ucy5qbA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

oschulz commented 2 years ago

Any objections, @devmotion ?

aplavin commented 2 years ago

bump

oschulz commented 2 years ago

bump

@devmotion ?

aplavin commented 2 years ago

Indeed! Splitting conditions into separate lines turned out to be helpful to catch this.

oschulz commented 2 years ago

Thanks @aplavin !

Since it looks like we're converging on #24 and #25 as well, I'll hold of with a release, Ok?