Closed aplavin closed 6 months ago
If we do this, I think we should support Dates for <v1.9 as well (as a direct dependency), via a
@static if !isdefined(Base, :get_extension)
include("../ext/DatesExt.jl")
end
@aplavin , should we get this one "home"?
Yes I think this is ready
@devmotion any objections to merging and releasing?
My apologies @aplavin , we lost track of this one. @devmotion any objections to merging this?
I'm very sorry for the delay @aplavin ! Merging this now.
Codecov Report
All modified lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #38 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 6 +1 Lines 121 129 +8 ========================================= + Hits 121 129 +8 ``` | [Files](https://app.codecov.io/gh/JuliaMath/InverseFunctions.jl/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [ext/DatesExt.jl](https://app.codecov.io/gh/JuliaMath/InverseFunctions.jl/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-ZXh0L0RhdGVzRXh0Lmps) | `100.00% <100.00%> (ø)` | | | [src/InverseFunctions.jl](https://app.codecov.io/gh/JuliaMath/InverseFunctions.jl/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-c3JjL0ludmVyc2VGdW5jdGlvbnMuamw=) | `100.00% <ø> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.