JuliaMath / MeasureTheory.jl

"Distributions" that might not add to one.
MIT License
386 stars 32 forks source link

Statement of Need #179

Closed ludgerpaehler closed 2 years ago

ludgerpaehler commented 2 years ago

Per Review Criteria

Do the authors clearly state what problems the software is designed to solve and who the target audience is?

I believe what would really help here is to more clearly establish the rules underlying the definition of a measure in the "Why", hence leading into the definition of a probability measure essentially adding the probability constraint. As is, the "Why" is a little hard to read for someone who does not already know measure theory.

cscherrer commented 2 years ago

Hi @ludgerpaehler , @mschauer and I were just discussing this. Most things under "Documentation" in the criteria seem to be about the repository, not the paper. Just to be sure we understand right, would adding this information in the documentation address your concern?

ludgerpaehler commented 2 years ago

@cscherrer sorry for the belated reply, yes, absolutely! My concerns were mostly about the docs :)

mschauer commented 2 years ago

199 now gives context and states the core audience (powering PPL work in Julia behind the scenes)

cscherrer commented 2 years ago

Ok to close @ludgerpaehler ?

ludgerpaehler commented 2 years ago

Sounds good to me!