JuliaMath / NFFT.jl

Julia implementation of the Non-equidistant Fast Fourier Transform (NFFT)
Other
153 stars 28 forks source link

allow CUDA 4 #115

Closed marius311 closed 1 year ago

marius311 commented 1 year ago

Allows CUDA.jl version 4. The main change is in that in CUDA 4, CUDA.functional() always returns false during precompilation, so the current thing doens't work (the package would load as empty). In any case, I don't think checking CUDA.functional() is the recommended thing even in prior versions, since CUDA will always load, so you can just define your functions regardless if later its loaded somewhere with or without functional CUDA.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a4cc6cf) 88.53% compared to head (0c3d312) 88.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #115 +/- ## ======================================= Coverage 88.53% 88.53% ======================================= Files 9 9 Lines 1116 1116 ======================================= Hits 988 988 Misses 128 128 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tknopp commented 1 year ago

makes sense, thank you.