JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
52 stars 26 forks source link

Avoid exporting vectorized functions with deprecation #15

Closed ararslan closed 7 years ago

ararslan commented 7 years ago

Using @dep_vectorize_1arg actually exports the functions, which causes errors since Base also exports the functions. This PR avoids exporting by manually constructing the deprecation rather than using the macro.

ararslan commented 7 years ago

It would be great if this this package could get another tag after this is merged. Having these functions exported makes it kind of annoying to track down all uses of sin and cos, for example, and qualify them with the Base prefix.

ararslan commented 7 years ago

Any chance you could tag another patch release, @mlubin? That'd be 💯

mlubin commented 7 years ago

done

ararslan commented 7 years ago

Thanks! <3 <3