search

JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
52 stars 26 forks source link

Functions for arbitrary-dimension arrays #19

Closed mkborregaard closed 7 years ago

mkborregaard commented 7 years ago

These functions are also often applied to e.g. Matrix{<:AbstractFloat} with NaNs, but currently there are only defined methods for Vectors. Are there plans to make them general? I guess it could be done with @generated functions using @nloops/@nref?

mkborregaard commented 7 years ago

Or possibly just changing the type signature to AbstractArray is enough.

mkborregaard commented 7 years ago

@dpsanders suggested that here. https://github.com/JuliaPlots/Plots.jl/issues/796#issuecomment-303979785 . Would you take a PR doing that?

mkborregaard commented 7 years ago

Bump - any feedback on the idea of replacing Vector with AbstractArray in the container-passing functions?

mlubin commented 7 years ago

Fine with me

mkborregaard commented 7 years ago

Great! https://github.com/mlubin/NaNMath.jl/pull/20