search

JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
52 stars 26 forks source link

Compatibility with multi-dimensional arrays; closes #19 #20

Closed mkborregaard closed 7 years ago

mkborregaard commented 7 years ago

:tada: Thanks a lot for working so promptly on this

mlubin commented 7 years ago

When you're happy with what's here, let me know and I can tag a new release.

mkborregaard commented 7 years ago

I'm quite happy now - it'd be nice to have the two-arg versions of the functions for multi-dim arrays too, but that is quite a lot more involved, of course. I have one last suggested PR that would save me essentially having to do the same thing downstream - dispatching all the one-arg versions with arguments that aren't AbstractVector{<:AbstractFloat} to the Base version.

See what you think - after merging this (or now, if you'd prefer not to merge that PR) I'd be happy for a release. This seems to have solved my problems downstream in Plots :-)