search

JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
52 stars 26 forks source link

Added docstring for sum, function sum is working with any floating point array now. #4

Closed ufechner7 closed 8 years ago

ufechner7 commented 8 years ago

This was tested with Julia 0.3 and Julia 0.4. On Julia 0.3 the import time increases due to the import of Docile (about one second on core i7).

ufechner7 commented 8 years ago

Any idea, why the checks are failing? I don't see any error message. Ok, now I see the error message: ERROR: Docile not found

ufechner7 commented 8 years ago

From what I can see in that travis log this is not a problem on 0.3, hence not really a Docile problem. It looks like the Julia 0.4 version being used on travis is older than the fix for the "LoadError: error in method definition: function Base.sum must be explicitly imported to be extended" error that you’re seeing there. You'll need to wait until the version is updated I guess.

mlubin commented 8 years ago

The .travis.yml here is old. I think we'll get a more recent 0.4 if it's updated to language: julia.

ufechner7 commented 8 years ago

Is everything ok now? From my point of view it looks fine.

mlubin commented 8 years ago

Looks good, could you squash the commits?

ufechner7 commented 8 years ago

I squashed them.