JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
52 stars 26 forks source link

Remove libm_name #55

Closed ViralBShah closed 1 year ago

ViralBShah commented 1 year ago

Not specifying the libm_name will pick the system libm. This is in preparation for https://github.com/JuliaLang/julia/pull/42299 where most of the pkgeval failures will be resolved with NaNMath being updated.

ViralBShah commented 1 year ago

@mlubin Would you also be ok with moving this package to JuliaMath?

ViralBShah commented 1 year ago

Still having issues with Windows. @mlubin Once you approve me for workflows (or transfer to JuliaMath), I can look into if these changes are good on Windows.

mlubin commented 1 year ago

The package is (somehow, unexpectedly) a critical part of the Julia ecosystem, so it makes sense for it to be in JuliaMath. What's the procedure for transferring to JuliaMath?

ViralBShah commented 1 year ago

I invited you to be a member of JuliaMath. Once you accept, you should be able to transfer. If not, I'll make you an owner of JuliaMath. Nothing much beyond that.

We should also update the registry, but since github forwards moved repos, that is not strictly required. Pinging @kristofferC just to make sure.

codecov-commenter commented 1 year ago

Codecov Report

Merging #55 (a269cae) into master (c42ecde) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a269cae differs from pull request most recent head 39dc40c. Consider uploading reports for the commit 39dc40c to get more accurate results

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files           1        1           
  Lines         104      104           
=======================================
  Hits           98       98           
  Misses          6        6           
Impacted Files Coverage Δ
src/NaNMath.jl 94.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c42ecde...39dc40c. Read the comment docs.

ViralBShah commented 1 year ago

@mlubin Can you merge once all green? I can then register the new version and run PkgEval again.

ViralBShah commented 1 year ago

I can't publish a new version of the package since I am not a collaborator on this repo. Can you add me, or move the package to JuliaMath?

mlubin commented 1 year ago

Already registered a new version: https://github.com/JuliaRegistries/General/pull/64196 Just transferred the repo.