search

JuliaMath / Polynomials.jl

Polynomial manipulations in Julia
http://juliamath.github.io/Polynomials.jl/
Other
303 stars 75 forks source link

Test using Aqua v0.8 #545

Closed jishnub closed 10 months ago

jishnub commented 10 months ago

Also, rewrite method signatures to get all the Aqua tests to pass. The idea there is that in the NTuple{N,T} form, T isn't known if N==0. Rewriting this as Tuple{T, Vararg{T}} ensures that T is not ambiguous.

jverzani commented 10 months ago

Thanks. You taught me about Vararg! Any thoughts on the stack overflow that happens with the ImmutablePolynomial type? (I didn't check,but my guess is there is an option to cut out a constructor.) I can pursue if you don't know right away what is up.

jverzani commented 10 months ago

Thanks,I merged this as part of #546. Hope I didn't miss the intent with my modifications. Do let me know if I missed something.