search

JuliaMath / Primes.jl

Prime numbers in Julia
Other
99 stars 32 forks source link

Allow DataStructures v0.18 #108

Closed ChrisRackauckas closed 2 years ago

ChrisRackauckas commented 2 years ago

DataStructures.jl is a core package and v0.18 was released in Aug 17, 2020. This means that pretty much any package made after that won't be compatible with Primes.jl in its latest form, so this shows up as a major ecosystem update blocker. We should really make sure that this kind of repo has CompatHelper.jl on it.

oscardssmith commented 2 years ago

Oops. Good catch. I'll merge once CI finishes.

oscardssmith commented 2 years ago

wait, this seems especially silly since the only place we use DataStructures is for a doctest.

ChrisRackauckas commented 2 years ago

😮‍💨 so make it a test dep?

oscardssmith commented 2 years ago

Do you want to make the PR or should I?

ChrisRackauckas commented 2 years ago

Can you? I'm going to have to take off and be gone for the rest of the day, but this is pretty necessary since it's causing quite a bit of downstream breakage.

oscardssmith commented 2 years ago

This is made slightly more complicated since this package supports Julia 1.0 which doesn't have test decencies (it uses [extras] instead. Also, as I understand it, test dependencies still need to be listed in the [compat] section (or am I missing something?). As such, I will merge this since it fixes the immediate problem.

ChrisRackauckas commented 2 years ago

and Tag?