search

JuliaMath / Primes.jl

Prime numbers in Julia
Other
99 stars 32 forks source link

I would like to re-use Primes.Factorization for polynomials #126

Closed jmichel7 closed 11 months ago

jmichel7 commented 1 year ago

I have written code for factoring a univariate polynomial over a finite field, and over the integers (modules Fact and FFfac in my package Gapjm). I thought it would be convenient to use Primes.Factorization to store these factorizations. However, I cannot since it is written in several places T<:Integer.

Are these annotations really useful? It seems to me they are not...

oscardssmith commented 1 year ago

I think this should be doable. I don't believe we are using the assumption of integer type anywhere.

jmichel7 commented 1 year ago

Excellent! I wait for this... Unless you want me to make a pr?

oscardssmith commented 1 year ago

can you make the PR? I'll merge.

jmichel7 commented 1 year ago

Thank you for merging! Are you going to do a release? It would be good to have this and also the function divisors ...

oscardssmith commented 1 year ago

I'm going to give myself a few days (mainly because I might want to get https://github.com/JuliaMath/Primes.jl/pull/120 in also). that said if I haven't made a release in a week or so, feel free to bump this.

as for divisors, I'm probably not going to write the code myself, but if there was a PR for it I probably would merge (even though I kind of think the multiplicative functions might belong in a separate package)

jmichel7 commented 1 year ago

But the code for divisors is already there in master!

oscardssmith commented 1 year ago

oh, that will be very easy then :)

jmichel7 commented 1 year ago

"if I haven't made a release in a week or so, feel free to bump this."

BUMP!

oscardssmith commented 1 year ago

version tagged. sorry for the wait.

fingolfin commented 11 months ago

Can this be closed?