search

JuliaMath / Primes.jl

Prime numbers in Julia
Other
99 stars 32 forks source link

Added .svg logo #131

Closed phlaster closed 1 year ago

phlaster commented 1 year ago

Hello! This is my first ever pull request. I've been writing in Julia for a while now and always wanted to contribute anything to the community, so as I've met your little package, I thought it deserves a logo. I used authentic Julia colours to draw it in Inkscape and put it into deps directory, as I saw the other Julia packages store icons and pictures there. Hope you'll find this little logo appropriate, and If so -- link it to README.md and to other places where the logo should be exposed.

oscardssmith commented 1 year ago

looks good! how are the colors chosen? I'm not sure everywhere the logo should be. probably the docs and on the GitHub repo. not sure if there's anywhere else

phlaster commented 1 year ago

I took the colors from julia-logo-graphics. The shape itself is the center of the Ulam spiral, which was the first thing, which came to my mind. At first I tried to set the colors according some obscure pattern, but then just spread them more or less at random.

Yeah, the docs was the first link I visited. It would be nice to see the logo there.

oscardssmith commented 1 year ago

looks good! how are the colors chosen? I'm not sure everywhere the logo should be. probably the docs and on the GitHub repo. not sure if there's anywhere else

oscardssmith commented 1 year ago

sorry for not getting back earlier. I think this is good to merge. I just futzed with it a little to try and make CI happy

phlaster commented 1 year ago

I had some time to think about this merge request, I'd better create commit with all changes needed (Including README.md and Docs updates). Now I am refining the logo, so I'd better close this one. screenshot