search

JuliaMath / Primes.jl

Prime numbers in Julia
Other
99 stars 32 forks source link

Update Documenter version #137

Closed oscardssmith closed 1 year ago

oscardssmith commented 1 year ago

@fingolfin this might also help with the docs

fingolfin commented 1 year ago

I don't think that's it. Rather we need to set some doctest metadata. I can submit a PR for this when I am back at my computer; it's a bit too annoying to debug this from my iPad ;-)

oscardssmith commented 1 year ago

lets see if the combination works.

fingolfin commented 1 year ago

Seems to work. The remaining failure is genuine; the comments in the output were manually added. One could discard them (but that would be a loss), or change the jldoctest into a plain julia block; or perhaps employ a doctest filter...

oscardssmith commented 1 year ago

Can you add the PR to make this have a doctest filter (since I don't really understand what that is)

fingolfin commented 1 year ago

See https://documenter.juliadocs.org/stable/man/doctests/#Filtering-Doctests -- but sure, I can make a PR