Closed rfourquet closed 6 years ago
I'm for 2
I'm not particularly excited about any usage of LinearAlgebra
here; it seems unrelated and not necessary as a dependency. I would be in favor of 2, for parity with the Base
function name.
(If retaining ⋅
is important, it seems like 4 would be a good choice. However, I doubt it would be necessary; sorry for the lack of clarity there. :slightly_smiling_face:)
Alright, let's go with 2 !
E.g.
Before, the
⋅
operator (\cdot
) was defined inBase
(equivalent todot
), so, the expression2^2 ⋅ 5
could be pasted back in the terminal and produce the input number, ie.20
. Now it works only ifLinearAlgebra
is imported. I see few solutions:LinearAlgebra
must be imported for that to work⋅
to*
⋅
to*
in theshow
method when we can detect thatLinearAlgebra
is not loadedshow(factor(20))
use*
and keep⋅
for the display at the REPL (suggested by @HarrisonGrodin, if I understood correctly)Primes
depend onLinearAlgebra
(I hope no-one will support this one!)I favor 1. and then 2.. I don't like 3 because the output depends on global state, and I find 4. to be slighly overkill. But after all, the star
*
is not so ugly, so 2. may be the most pragmatic solution. Other ideas?