JuliaMath / Primes.jl

Prime numbers in Julia
Other
99 stars 32 forks source link

WIP: upgrade factor!, and maybe remove factor(ContainerType, n) #80

Open rfourquet opened 4 years ago

rfourquet commented 4 years ago

Cf. discussion at https://github.com/JuliaMath/Primes.jl/pull/78#discussion_r352474088. This allows for example factor(Int[], 123). Should we remove factor(Vector, 123), deprecated it? Or should we just remove the generic methods (factor(::Type{AbstractArray}), factor(::Type{AbstractDict}), etc.) and keep the ones with Base types (which we know how to instantiate)? I would just remove them all before we tag 1.0.