JuliaMath / QuadGK.jl

adaptive 1d numerical Gauss–Kronrod integration in Julia
MIT License
268 stars 37 forks source link

Update adapt.jl #74

Closed Hmegh closed 1 year ago

Hmegh commented 1 year ago

Currently, quadgk_print is missing a right parenthesis. For example:

quadgk_print(x->1,0,1)

returns

f(0.39610752249605075 = 1
f(0.6038924775039493 = 1
f(0.025446043828620757 = 1
f(0.9745539561713792 = 1
f(0.004272314439593694 = 1
f(0.9957276855604063 = 1
f(0.12923440720030277 = 1
f(0.8707655927996972 = 1
f(0.06756778832011545 = 1
f(0.9324322116798845 = 1
f(0.2970774243113014 = 1
f(0.7029225756886985 = 1
f(0.20695638226615443 = 1
f(0.7930436177338456 = 1
(1.0, 0.0, 15)
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b4803e5) 97.62% compared to head (c851321) 97.62%.

:exclamation: Current head c851321 differs from pull request most recent head ad4bfc2. Consider uploading reports for the commit ad4bfc2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #74 +/- ## ======================================= Coverage 97.62% 97.62% ======================================= Files 5 5 Lines 337 337 ======================================= Hits 329 329 Misses 8 8 ``` | [Impacted Files](https://codecov.io/gh/JuliaMath/QuadGK.jl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [src/adapt.jl](https://codecov.io/gh/JuliaMath/QuadGK.jl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-c3JjL2FkYXB0Lmps) | `97.29% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stevengj commented 1 year ago

Whoops, good catch!

Can you also fix the example in the manual?

Hmegh commented 1 year ago

Whoops, good catch!

Can you also fix the example in the manual?

Done, I updated the example in the manual.

stevengj commented 1 year ago

Thanks!