Open lxvm opened 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
135432c
) 98.21% compared to head (f328bd7
) 98.27%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stevengj this pr is now updated to pass unitless limits to do_quadgk
and the new tests are more careful about verifying this behavior.
Here are also timings on Julia 1.10 that show a median slowdown under 2.5% in general:
branch | integrand | median time |
---|---|---|
pr | x | 35.839 ns |
master | x | 35.007 ns |
pr | sin(100x) | 11.965 μs |
master | sin(100x) | 11.762 μs |
I think this is ready and could be a patch release
Fixes #95 This pr changes
handle_infinities
to always pass limits with units todo_quadgk
so that the samesegbuf
can be used with finite and infinite limits. It also adds some tests to check this works for inplace and batched integrands.Unfortunately, the endpoints of the segments in a segbuf don't correspond to the intervals used in the original domain when using the infinity transformation. However, changing that would be a lot more involved than what is needed for this pr.