search

JuliaMath / openlibm

High quality system independent, portable, open source libm implementation
https://openlibm.org
Other
507 stars 139 forks source link

makefile error #281

Closed achan001 closed 7 months ago

achan001 commented 11 months ago

I donwloaded openlibm v0.8.1 and strawberry perl 5.32.1.1 Perl come supplied with gcc 8.3.0 (i686-w64-mingw32)

Using gmake, it did compile to static library, in my old Win7 laptop. But, it grabbed i387/s_tan.S (with inaccurate fptan) rather than src/s_tan.c

Test suite was unable to detect this. (all run successfully)

I just manually compile s_tan.c to replace s_tan.S, Everything work now. It might be better to fix it in makefile instead.

BTW, very nice math library!

ViralBShah commented 8 months ago

If you are able to provide a PR to the build system, it will be helpful, since I do not have access to such a system.