search

JuliaMath / openlibm

High quality system independent, portable, open source libm implementation
https://openlibm.org
Other
507 stars 139 forks source link

CMake Changes #299

Closed theoparis closed 2 months ago

theoparis commented 6 months ago
ViralBShah commented 5 months ago

Merge?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.02%. Comparing base (4b83beb) to head (a1fdd7c). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #299 +/- ## ========================================== + Coverage 38.24% 39.02% +0.78% ========================================== Files 233 233 Lines 6139 6144 +5 Branches 1607 1607 ========================================== + Hits 2348 2398 +50 + Misses 3394 3393 -1 + Partials 397 353 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ViralBShah commented 2 months ago

Can you rebase to master? Is this ok to merge given the changes in #302? It looks like there is no conflict.

ViliusSutkus89 commented 2 months ago

Hello @theoparis , could you confirm that the current git version works for you with FetchContent?

Also, if you don't mind me asking, have you tried using package managers instead of FetchContent? I'm assuming you're using it to pull OpenLibm into your project