Closed ViliusSutkus89 closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.02%. Comparing base (
4b83beb
) to head (2899a5e
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello,
Thanks for the library. I'm trying to use it through CMake, but I've noticed a couple of lines that could be added there. I've changed to version number, to match the actual current number - 0.8.2. Added install command, to allow running
cmake install
, which installs the library and public headers from included directories. Directories are added to the search path usingtarget_include_directories
, so there's no need to add them using CFlags. 64 bit ARM architecture can be defined as aarch64, so I've added that to the if statement, which selects arch folder.I've also added
BUILD_SHARED_LIBS
option. In this regard, this patch does the same as @theoparis suggested in #299, but according to CMake docs, the option string is also needed. The resultingadd_library
call is the same, so both PR's should be able to merge.I've tried running the changes in CI, but somewhy windows clang64 errors about complaining about missing gcc. I haven't touched that part, so I assume the CI should error out without these changes too
Regards, Vilius