JuliaMath / openlibm

High quality system independent, portable, open source libm implementation
https://openlibm.org
Other
507 stars 139 forks source link

CMake changes: Long double/double size detection, Android x86 and armv7 support, install pkg-config pc file #304

Closed ViliusSutkus89 closed 2 months ago

ViliusSutkus89 commented 2 months ago

Hello,

This PR has the following changes:

Also, when we release, we need to update version number at the top of CMakeLists.txt file, otherwise the generated pkg-config openlibm.pc file will report the wrong version. I've set the version to 0.8.4 in advance. I don't really care about it, because I don't use pkg-config.pc file, I'm just saying what would be the consequences of not incrementing the version number. Where do we set the version number for pkg-config.pc file generated by autotools?

Once again, #299 will require a merge commit, because it's the same file we are editing, but we touched different lines, so we should be good.

Regards

ViralBShah commented 2 months ago

@ViliusSutkus89 Happy to give you commit access here. Please let me know if ok.

ViliusSutkus89 commented 2 months ago

Sure. I can't be a full time maintainer, but I'll try to help whenever I can

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.02%. Comparing base (4b83beb) to head (c1e8462). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #304 +/- ## ========================================== + Coverage 38.24% 39.02% +0.78% ========================================== Files 233 233 Lines 6139 6144 +5 Branches 1607 1608 +1 ========================================== + Hits 2348 2398 +50 + Misses 3394 3393 -1 + Partials 397 353 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ViliusSutkus89 commented 2 months ago

Updated PR with a patch to match version in CMake with the version in Autotools