JuliaMath / openlibm

High quality system independent, portable, open source libm implementation
https://openlibm.org
Other
507 stars 139 forks source link

Fix risc-v build #305

Closed tea closed 1 month ago

tea commented 1 month ago

Two fixes in one:

Firstly, replace non-standard uint64_t with standard (but optional) uint64_t. uint64_t is not a part of C standard; it is defined by some platforms but might not be present in every environment (e.g. in freestanding build). On the other hand, uint64_t is standard C. It is optional but virtually guaranteed to be present for any 32/64 bit machine.

Secondly, mark riscv64 for 128-bit long double in make/cmake files. This fixes cmake build (which detects presence of long double and tries to compile extended functions), and brings make build to do the same.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.02%. Comparing base (c1e8462) to head (a91cde1). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #305 +/- ## ======================================= Coverage 39.02% 39.02% ======================================= Files 233 233 Lines 6144 6144 Branches 1608 1607 -1 ======================================= Hits 2398 2398 Misses 3393 3393 Partials 353 353 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.