Compile on Solaris 11 (Solaris 11 zone on SmartOS)

[ccrusius]

Where? Is this a style preference or something that affects the code?

[nalimilan]

Where? Is this a style preference or something that affects the code?

I don't know, but you seem to have aligned the values of defines in some lines, and not in others.

Otherwise, looks good to me -- but I have no experience with these issues, I just checked everything was consistent with the previous code.

[ccrusius]

Whatever alignment is there is accidental - I indented the preprocessor directives to make it easier to read, but that was all.

[ccrusius]

On the comments: I did close the pull request when I realized this, but then I realized that the code uses // in all sorts of places anyway, such as rem_pio2/openlibm.h, rem_pio2/math_private.h, and so on. No use in fixing mine if all are not fixed.

[ccrusius]

In particular,

15:42:37 crusius@solaris:/zones/sfw/openspecfun.git git grep -l // | grep pio2
rem_pio2/Make.files
rem_pio2/e_rem_pio2.c
rem_pio2/e_rem_pio2f.c
rem_pio2/fpmath.h
rem_pio2/k_rem_pio2.c
rem_pio2/math_private.h
rem_pio2/openlibm.h

[nalimilan]

No use in fixing mine if all are not fixed.

Right. But please fix these alignment issues, either by removing padding completely or by consistently aligning them. The place where I noticed this is # define _FPMATH_BYTE_ORDER __BYTE_ORDER (compared with lines above).

BTW, you don't need to reopen a pull request, just update it with git push --force.

[ccrusius]

Change updated.

[nalimilan]

Let's wait for somebody else to comment and merge.

[staticfloat]

LGTM