search

JuliaMath / openspecfun

A collection of special mathematical functions
Other
35 stars 20 forks source link

Use `override` with `-fPIC` option so it is ALWAYS included #3

Closed staticfloat closed 10 years ago

staticfloat commented 10 years ago

I'm a little dissatisfied with the CFLAGS_add solutions in Make.inc. make gives us two behaviors for assigning variables: those that the user can overturn easily (=, +=, :=) and those that they cannot (prefixed with override). By creating a nonstandard variable name, we create a second tier of overridable values in the Makefile.

I think it would be more straightforward for everyone involved if we just separate the Makefile into default {C,F}FLAG values, and those that cannot be overridden, added onto the {C,F}FLAG values via override.

Viral, if you agree, I'll update this PR with the changes.

ViralBShah commented 10 years ago

I think it would be good to have flags that can and cannot be overridden. You also have commit access to this repo.

staticfloat commented 10 years ago

Alright. I will then have a CFLAGS_add and FFLAGS_add that use the override keyword such that they cannot be overturned by the user, but CFLAGS is all still up for grabs by the user.